Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gossip Autogenerate Command #789

Merged
merged 5 commits into from
Oct 20, 2021
Merged

Use Gossip Autogenerate Command #789

merged 5 commits into from
Oct 20, 2021

Conversation

t-eckert
Copy link
Contributor

@t-eckert t-eckert commented Oct 18, 2021 •
edited
Loading

Changes proposed in this PR:

  • Add get perm to gossip autogenerate role
  • Use imageK8S and run command from job

How I've tested this PR:

I pushed an image of the control plane on the main branch to tecke/consul-k8s-dev. You can test running the autogeneration flag with the following Helm values:

global:
  gossipEncryption:
    autoGenerate: true
  imageK8S: "tecke/consul-k8s-dev"
  enabled: true

How I expect reviewers to test this PR:

Reviewers can test the PR using the same settings listed above. They may also wish to check that bats tests pass.

Reviewers, do you see any need for additional bats tests as a result of this change?

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@t-eckert t-eckert requested review from a team, kschoche, sadjamz and ishustava and removed request for a team and sadjamz October 18, 2021 15:03
ishustava
ishustava approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Thomas, this looks good!

Just one minor comment, but I'm approving assuming this will be fixed before merging.

charts/consul/templates/gossip-encryption-autogenerate-job.yaml Outdated Show resolved Hide resolved
@t-eckert
Copy link
Contributor Author

I'm having trouble debugging the failing acceptance test. Putting a sticky note here that I'll need a buddy to help me get unblocked.

@t-eckert
Copy link
Contributor Author

I'm having trouble debugging the failing acceptance test. Putting a sticky note here that I'll need a buddy to help me get unblocked.

Never mind, just an intermittent issue.

lkysow
lkysow approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@t-eckert t-eckert merged commit 68a0520 into main Oct 20, 2021
@t-eckert t-eckert deleted the use-gossip-autogen branch October 20, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschoche kschoche kschoche approved these changes

@ishustava ishustava ishustava approved these changes

@lkysow lkysow lkysow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@t-eckert @lkysow @kschoche @ishustava